Clarify Renderer discrepancy #4102
Conversation
|
@WinterSilence @kenjis anything to add? |
|
@MGatner class ViewConfig extends BaseConfig
{
/**
* @var boolean ...
*/
public $saveData = false;
....
}and replace CodeIgniter4/system/View/View.php Line 145 in 0489678 $this->saveData = (bool) $config->saveData;
Also, need fix |
|
@WinterSilence Thank you, all good fixes. Please re-review. |
| * | ||
| * @var boolean | ||
| */ | ||
| public $saveData = true; |
There was a problem hiding this comment.
it's can be false by default - RendererInterface::render(string $view, array $options = null, bool $saveData = false)
There was a problem hiding this comment.
It is true in app/Config/View.php which extends this, so I think it makes more sense to mirror that.
There was a problem hiding this comment.
@MGatner why not same to RendererInterface::render()?
There was a problem hiding this comment.
I have no clue, I didn't write any of this. Probably a mistake or miscommunication among earlier devs. At this point though we have a public interface which we can't change and an App config file which we could change but would need to note in docs - I think keeping the config files consistent even though they don't match the interface makes the most sense given the mess it already is.
Description
Fixes a discrepancy between the interface docblock and the actual method definitions. Clarifies the usage in
View.Checklist: